flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5625) Let Date format for timestamp-based start position in Kinesis consumer be configurable.
Date Thu, 30 Mar 2017 08:14:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948626#comment-15948626
] 

ASF GitHub Bot commented on FLINK-5625:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3651#discussion_r108865011
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
    @@ -224,27 +222,19 @@ private static void validateOptionalPositiveDoubleProperty(Properties
config, St
     		}
     	}
     
    -	private static void validateOptionalDateProperty(Properties config, String timestampKey,
String formatKey, String message) {
    +	private static void validateOptionalDateProperty(Properties config, String timestampKey,
String format, String message) {
     		if (config.containsKey(timestampKey)) {
    -			if (config.containsKey(formatKey)) {
    -				try {
    -					SimpleDateFormat customDateFormat = new SimpleDateFormat(config.getProperty(formatKey));
    -					customDateFormat.parse(config.getProperty(timestampKey));
    -				} catch (ParseException | IllegalArgumentException | NullPointerException exception)
{
    -					throw new IllegalArgumentException(message);
    -				}
    -			} else {
    +			try {
    +				SimpleDateFormat customDateFormat = new SimpleDateFormat(format);
    +				customDateFormat.parse(config.getProperty(timestampKey));
    +			} catch (ParseException | IllegalArgumentException | NullPointerException exception)
{
    --- End diff --
    
    Yes, or something similar. Generally, I don't think the two conditions should be handled
with the same `catch` branch.


> Let Date format for timestamp-based start position in Kinesis consumer be configurable.
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-5625
>                 URL: https://issues.apache.org/jira/browse/FLINK-5625
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Wei-Che Wei
>
> Currently, the Kinesis consumer's Date format for timestamp-based start positions is
fixed. It'll be nice to make this format configurable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message