flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths
Date Tue, 14 Mar 2017 12:55:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924118#comment-15924118
] 

ASF GitHub Bot commented on FLINK-5090:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r105898097
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -389,11 +389,20 @@ public Task(
     			++counter;
     		}
     
    +		invokableHasBeenCanceled = new AtomicBoolean(false);
    +
    +		// finally, create the executing thread, but do not start it
    +		executingThread = new Thread(TASK_THREADS_GROUP, this, taskNameWithSubtask);
    +
    +		// add metrics for buffers
    +		this.metrics.getIOMetricGroup().initializeBufferMetrics(this);
    +
     		// register detailed network metrics, if configured
     		if (tmConfig.getBoolean(TaskManagerOptions.NETWORK_DETAILED_METRICS_KEY)) {
    -			MetricGroup networkGroup = metricGroup.addGroup("Network"); // same as in MetricUtils.instantiateNetworkMetrics()
    -			MetricGroup outputGroup = networkGroup.addGroup("Output"); // this is optional
    -			MetricGroup inputGroup = networkGroup.addGroup("Input"); // this is optional
    +			// similar to MetricUtils.instantiateNetworkMetrics() but inside this IOMetricGroup
    +			MetricGroup networkGroup = this.metrics.getIOMetricGroup().addGroup("Network");
    --- End diff --
    
    ok, thanks for the clarification - I'll keep it the way it is now though since this "modified"
code is actually new in this PR and this way at least, it is somewhat consistent with the
code from MetricUtils


> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
>                 Key: FLINK-5090
>                 URL: https://issues.apache.org/jira/browse/FLINK-5090
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics, Network
>    Affects Versions: 1.1.3
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed metrics about
the length of network input and output queues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message