flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule
Date Thu, 16 Mar 2017 16:41:45 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928400#comment-15928400

ASF GitHub Bot commented on FLINK-3849:

Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
    @@ -18,20 +18,20 @@
     package org.apache.flink.table.utils
    -import org.apache.calcite.rel.RelWriter
     import org.apache.flink.api.common.typeinfo.TypeInformation
     import org.apache.flink.api.java.typeutils.RowTypeInfo
     import org.apache.flink.api.java.{DataSet, ExecutionEnvironment}
     import org.apache.flink.streaming.api.datastream.DataStream
     import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment
     import org.apache.flink.table.api.Types._
     import org.apache.flink.table.expressions._
    -import org.apache.flink.table.sources.{BatchTableSource, FilterableTableSource, StreamTableSource}
    +import org.apache.flink.table.sources.{BatchTableSource, FilterableTableSource, StreamTableSource,
     import org.apache.flink.types.Row
     import org.apache.flink.util.Preconditions
     import scala.collection.JavaConverters._
     import scala.collection.mutable
    +import scala.tools.nsc.interpreter.JList
    --- End diff --
    change to `import java.util.{List => JList}`?

> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>                 Key: FLINK-3849
>                 URL: https://issues.apache.org/jira/browse/FLINK-3849
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Kurt Young
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations which support
filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
>   // returns unsupported predicate expression
>   def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a TableScan
that refers to a {{FilterableTableSource}}. We might need to tweak the cost model as well
to push the optimizer in the right direction.

This message was sent by Atlassian JIRA

View raw message