flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule
Date Thu, 16 Mar 2017 01:59:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927319#comment-15927319
] 

ASF GitHub Bot commented on FLINK-3849:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3520#discussion_r106324883
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
    @@ -58,16 +60,24 @@ class BatchTableSourceScan(
         )
       }
     
    +  override def copy(traitSet: RelTraitSet, newTableSource: TableSource[_]): TableSourceScan
= {
    +    new BatchTableSourceScan(
    +      cluster,
    +      traitSet,
    +      getTable,
    +      newTableSource.asInstanceOf[BatchTableSource[_]]
    +    )
    +  }
    +
       override def explainTerms(pw: RelWriter): RelWriter = {
    -    super.explainTerms(pw)
    +    val terms = super.explainTerms(pw)
           .item("fields", TableEnvironment.getFieldNames(tableSource).mkString(", "))
    +    tableSource.explainTerms(terms)
    --- End diff --
    
    will change this.


> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>
>                 Key: FLINK-3849
>                 URL: https://issues.apache.org/jira/browse/FLINK-3849
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Kurt Young
>
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations which support
filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
>   // returns unsupported predicate expression
>   def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a TableScan
that refers to a {{FilterableTableSource}}. We might need to tweak the cost model as well
to push the optimizer in the right direction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message