flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Lucas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry
Date Thu, 09 Mar 2017 16:24:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903317#comment-15903317
] 

Patrick Lucas commented on FLINK-3026:
--------------------------------------

Yes, I gave you contributor permissions. This repo is really just a stop-gap until we find
a permanent home for these scripts, such as in docker-library. I'm fairly convinced that these
should be versioned independently of Flink (in a separate repo), as they are updated as a
consequence of Flink releases and are not themselves part of a given release. Moreover, the
scripts herein may relate to many different "stable" branches of Flink.

And I don't really see how it would be feasible to make the contents of this repo somehow
"downstream" from the Docker support included in apache/flink as I think they serve different
purposes. In apache/flink, having a Dockerfile to package up the current tree would be useful
for development, and as a baseline if a user wanted to create their own images from scratch.
The docker-flink repo meanwhile encodes the generation of all Dockerfile variants for all
"stable" versions of Flink.

Finally, I think a tenet of this work (Docker support) going forward should be that the Dockerfile
templates really should not change much over time. Instead, we should try to make any changes
in functionality in Flink itself, and keep the Dockerfiles (and docker-entrypoint.sh scripts)
as simple as possible. If we're doing things right, this code should very rarely change, except
when we need to generate Dockerfiles for a new Flink release.

> Publish the flink docker container to the docker registry
> ---------------------------------------------------------
>
>                 Key: FLINK-3026
>                 URL: https://issues.apache.org/jira/browse/FLINK-3026
>             Project: Flink
>          Issue Type: Task
>          Components: Build System, Docker
>            Reporter: Omer Katz
>            Assignee: Patrick Lucas
>              Labels: Deployment, Docker
>
> There's a dockerfile that can be used to build a docker container already in the repository.
It'd be awesome to just be able to pull it instead of building it ourselves.
> The dockerfile can be found at https://github.com/apache/flink/tree/master/flink-contrib/docker-flink
> It also doesn't point to the latest version of Flink which I fixed in https://github.com/apache/flink/pull/1366



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message