flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #3655: [FLINK-6175] Harden HistoryServerTest#testFullArchiveLife...
Date Fri, 31 Mar 2017 08:02:23 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3655
  
    It would be less intrusive, that's true. I do prefer staying away from mockito magic as
far as possible though Mockito often results in failing tests even though no public contract
was modified/violated: in those 4 lines alone you rely on 3 _internal_ details to not change
for the test to succeed (name of the Field, class of the Field, way of execution (run()).
    
    This now means that when the implementation changes so must the test, which kind of defeats
their purpose of comparing a new implementation to a known use-case; as well as introducing
a risk for additional bugs to sneak in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message