flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3616: [FLINK-6188] Correctly handle PARALLELISM_DEFAULT ...
Date Thu, 30 Mar 2017 14:42:24 GMT
Github user kl0u commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java
    @@ -202,7 +203,17 @@ public int getParallelism() {
     	 * @param parallelism The new parallelism to set on this {@code StreamTransformation}
     	public void setParallelism(int parallelism) {
    -		Preconditions.checkArgument(parallelism > 0, "Parallelism must be bigger than zero.");
    +		checkArgument(parallelism != ExecutionConfig.PARALLELISM_UNKNOWN, "Cannot specify UNKNOWN_PARALLELISM.");
    --- End diff --
    The `PARALLELISM_UNKNOWN` does not seem to be used anywhere in the codebase, apart from
checking against it. Couldn't we remove it? Or am I missing something?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message