flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3522: [FLINK-5823] [checkpoints] State Backends also han...
Date Thu, 30 Mar 2017 14:23:15 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3522#discussion_r108729089
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java
---
    @@ -18,33 +18,89 @@
     
     package org.apache.flink.runtime.state.memory;
     
    +import org.apache.flink.annotation.PublicEvolving;
     import org.apache.flink.api.common.JobID;
     import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.FileStatus;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.checkpoint.CompletedCheckpoint;
     import org.apache.flink.runtime.execution.Environment;
     import org.apache.flink.runtime.query.TaskKvStateRegistry;
     import org.apache.flink.runtime.state.AbstractKeyedStateBackend;
    -import org.apache.flink.runtime.state.AbstractStateBackend;
     import org.apache.flink.runtime.state.CheckpointStreamFactory;
    +import org.apache.flink.runtime.state.ConfigurableStateBackend;
     import org.apache.flink.runtime.state.KeyGroupRange;
    +import org.apache.flink.runtime.state.filesystem.AbstractFileStateBackend;
     import org.apache.flink.runtime.state.heap.HeapKeyedStateBackend;
    +import org.apache.flink.util.FlinkException;
    +
    +import javax.annotation.Nullable;
     
     import java.io.IOException;
     
    +import static org.apache.flink.util.Preconditions.checkArgument;
    +
     /**
    - * A {@link AbstractStateBackend} that stores all its data and checkpoints in memory
and has no
    - * capabilities to spill to disk. Checkpoints are serialized and the serialized data
is
    - * transferred
    + * This state backend holds the working state in the memory (JVM heap) of the TaskManagers.
    + * The state backend checkpoints state directly the JobManager's memory (hence the backend's
name),
    --- End diff --
    
    preposition seems to be missing here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message