flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony810430 <...@git.apache.org>
Subject [GitHub] flink pull request #3651: [FLINK-5625] [kinesis] Let Date format for timesta...
Date Thu, 30 Mar 2017 06:24:01 GMT
Github user tony810430 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3651#discussion_r108848825
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
    @@ -115,10 +116,21 @@ protected ShardConsumer(KinesisDataFetcher<T> fetcherRef,
     
     		if (lastSequenceNum.equals(SentinelSequenceNumber.SENTINEL_AT_TIMESTAMP_SEQUENCE_NUM.get()))
{
     			String timestamp = consumerConfig.getProperty(ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP);
    -			try {
    -				this.initTimestamp = KinesisConfigUtil.initTimestampDateFormat.parse(timestamp);
    -			} catch (ParseException e) {
    -				this.initTimestamp = new Date((long) (Double.parseDouble(timestamp) * 1000));
    +
    +			if (consumerConfig.containsKey(ConsumerConfigConstants.STREAM_TIMESTAMP_DATE_FORMAT))
{
    --- End diff --
    
    You are right. I will fix it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message