flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hongyuhong <...@git.apache.org>
Subject [GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...
Date Sat, 25 Mar 2017 02:48:22 GMT
Github user hongyuhong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3386#discussion_r108026230
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
    @@ -112,7 +113,12 @@ class DataStreamOverAggregate(
                   "condition.")
             }
           case _: RowTimeType =>
    -        throw new TableException("OVER Window of the EventTime type is not currently
supported.")
    +        if (overWindow.lowerBound.isUnbounded && overWindow.upperBound.isCurrentRow)
{
    +          createUnboundedAndCurrentRowEventTimeOverWindow(inputDS)
    --- End diff --
    
    Hi @sunjincheng121´╝îthanks for your reminding, and i am glad to supplement it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message