flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3573: [FLINK-6129] [metrics] Stop query actor of MetricR...
Date Thu, 23 Mar 2017 08:57:29 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
    @@ -209,14 +223,29 @@ public void shutdown() {
     			reporters = null;
    +		if (stopFuture != null) {
    --- End diff --
    if the MQS is started while a shutdown is in progress it might not be cleaned up. What
do you think about adding a lock here and in startMetricQueryService?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message