flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows
Date Wed, 22 Mar 2017 15:43:14 GMT
Github user tzulitai commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
    @@ -138,7 +138,7 @@
     	 * {@code window.maxTimestamp + allowedLateness} is smaller than the current watermark
     	 * be emitted to this.
    -	private final OutputTag<IN> lateDataOutputTag;
    +	protected final OutputTag<IN> lateDataOutputTag;
    --- End diff --
    Ah, sorry I mistakened that it was exposed for testing. `protected` would be fine then.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message