flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaoxuan-wang <...@git.apache.org>
Subject [GitHub] flink pull request #3593: [FLINK-6124] [table] Add min/max string aggregatio...
Date Wed, 22 Mar 2017 13:24:08 GMT
Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3593#discussion_r107410682
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
    @@ -201,14 +201,22 @@ class DoubleMaxWithRetractAggFunction extends MaxWithRetractAggFunction[Double]
       * Built-in Boolean Max with retraction aggregate function
       */
     class BooleanMaxWithRetractAggFunction extends MaxWithRetractAggFunction[Boolean] {
    -  override def getInitValue = false
    +  override def getInitValue: Boolean = false
       override def getValueTypeInfo = BasicTypeInfo.BOOLEAN_TYPE_INFO
     }
     
     /**
       * Built-in Big Decimal Max with retraction aggregate function
       */
     class DecimalMaxWithRetractAggFunction extends MaxWithRetractAggFunction[BigDecimal]
{
    -  override def getInitValue = BigDecimal.ZERO
    +  override def getInitValue: BigDecimal = BigDecimal.ZERO
       override def getValueTypeInfo = BasicTypeInfo.BIG_DEC_TYPE_INFO
     }
    +
    +/**
    +  * Built-in String Max with retraction aggregate function
    +  */
    +class StringMaxWithRetractAggFunction extends MaxWithRetractAggFunction[String] {
    +  override def getInitValue: String = ""
    --- End diff --
    
    remove ": String"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message