flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...
Date Tue, 21 Mar 2017 03:44:57 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3574#discussion_r107066745
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -89,6 +95,18 @@ object AggregateUtil {
             aggregationStateType)
         }
       }
    + 
    +  def getLowerBoundary(
    +      constants: ImmutableList[RexLiteral],
    +      lowerBound: RexWindowBound,
    +      input: RelNode): Int = {
    +    val ref: RexInputRef = lowerBound.getOffset.asInstanceOf[RexInputRef]
    +    val index:Int = ref.getIndex
    +    val count: Int = input.getRowType.getFieldCount
    --- End diff --
    
    Can you explain more why we using `input.getRowType.getFieldCount` to calculation the
LowerBoundary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message