flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...
Date Mon, 20 Mar 2017 20:15:16 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3574#discussion_r106958710
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
    @@ -150,12 +160,71 @@ class DataStreamOverAggregate(
                 inputType,
                 false)
     
    -          inputDS
    -            .process(processFunction).setParallelism(1).setMaxParallelism(1)
    -            .returns(rowTypeInfo)
    -            .name(aggOpName)
    -            .asInstanceOf[DataStream[Row]]
    -        }
    +        inputDS
    +          .process(processFunction).setParallelism(1).setMaxParallelism(1)
    +          .returns(rowTypeInfo)
    +          .name(aggOpName)
    +          .asInstanceOf[DataStream[Row]]
    +      }
    +    result
    +  }
    +
    +  def createBoundedAndCurrentRowProcessingTimeOverWindow(
    +    inputDS: DataStream[Row]): DataStream[Row] = {
    +
    +    val overWindow: Group = logicWindow.groups.get(0)
    +    val partitionKeys: Array[Int] = overWindow.keys.toArray
    +    val namedAggregates: Seq[CalcitePair[AggregateCall, String]] = generateNamedAggregates
    +
    +    // get the output types
    +    val rowTypeInfo = FlinkTypeFactory.toInternalRowTypeInfo(getRowType).asInstanceOf[RowTypeInfo]
    +
    +    // window size is lowerbound +1 to comply with over semantics 
    +    val lowerbound: Int = AggregateUtil.getLowerBoundary(
    +      logicWindow.constants,
    +      overWindow.lowerBound,
    +      getInput()) + 1
    +
    +    val (aggFunction, accumulatorRowType, aggResultRowType) =
    +      AggregateUtil.createDataStreamOverAggregateFunction(
    +        namedAggregates,
    +        inputType,
    +        rowRelDataType,
    +        partitionKeys)
    +    val aggString = aggregationToString(
    --- End diff --
    
    `aggString` is not used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message