flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3508: [FLINK-5991] [state-backend, streaming] Expose Broadcast ...
Date Thu, 16 Mar 2017 13:21:04 GMT
Github user StephanEwen commented on the issue:

    Looks good in general. Some thoughts on refinement:
      - I think we should not really encourage the use of Java Serialization, so I would suggest
to remove the serializable shortcut for broadcast state. We have it for the default operator
state only as a bridge to mimick the previous behavior (easier migration)
      - Since broadcast state already defines its redistribution pattern (broadcast), the
shape of the datastructure is orthogonal. We can for example also have broadcast map state,
broadcast value state, etc. Hence, I would suggest to take "list" somewhere into the name
of the methods.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message