flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...
Date Wed, 15 Mar 2017 17:31:03 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java
    @@ -0,0 +1,107 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.state.heap;
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.state.ListStateDescriptor;
    +import org.apache.flink.api.common.typeutils.base.IntSerializer;
    +import org.apache.flink.api.common.typeutils.base.StringSerializer;
    +import org.apache.flink.runtime.query.TaskKvStateRegistry;
    +import org.apache.flink.runtime.state.KeyGroupRange;
    +import org.apache.flink.runtime.state.KeyGroupsStateHandle;
    +import org.apache.flink.runtime.state.internal.InternalListState;
    +import org.apache.flink.util.InstantiationUtil;
    +import org.apache.flink.util.Preconditions;
    +import org.junit.Test;
    +import java.io.BufferedInputStream;
    +import java.io.FileInputStream;
    +import java.net.URL;
    +import java.util.Collections;
    +import static java.util.Arrays.asList;
    +import static org.junit.Assert.assertEquals;
    +import static org.mockito.Mockito.mock;
    +public class HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest {
    +	/**
    +	 * This test takes a snapshot that was created with Flink 1.2 and tries to restore it
in Flink 1.3 to check
    +	 * the backwards compatibility of the serialization format of {@link StateTable}s.
    +	 */
    +	@Test
    +	public void testHeapKeyedStateBackend1_2To1_3BackwardsCompatibility() throws Exception
    --- End diff --
    I think this should be something like `testRestore12ToCurrent` or `testRestore12ToMaster`
because that is in fact what it does. Otherwise we would have to hunt down all instances of
11To13 and rename them to 11To14 when we release.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message