flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...
Date Wed, 15 Mar 2017 17:31:03 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapMergingState.java
    @@ -47,77 +44,62 @@
     	 * Creates a new key/value state for the given hash map of key/value pairs.
    -	 * @param backend The state backend backing that created this state.
     	 * @param stateDesc The state identifier for the state. This contains name
     	 *                           and can create a default state value.
     	 * @param stateTable The state tab;e to use in this kev/value state. May contain initial
     	protected AbstractHeapMergingState(
    -			KeyedStateBackend<K> backend,
     			SD stateDesc,
     			StateTable<K, N, SV> stateTable,
     			TypeSerializer<K> keySerializer,
     			TypeSerializer<N> namespaceSerializer) {
    -		super(backend, stateDesc, stateTable, keySerializer, namespaceSerializer);
    +		super(stateDesc, stateTable, keySerializer, namespaceSerializer);
    +		this.mergeTransformation = new MergeTransformation();
    +	private final MergeTransformation mergeTransformation;
    --- End diff --
    Curious placement of field. 😉 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message