flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #3546: [FLINK-6059] [table] Reject GenericType<Row> when ...
Date Wed, 15 Mar 2017 16:28:10 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
    @@ -498,6 +505,10 @@ abstract class TableEnvironment(val config: TableConfig) {
    --- End diff --
    Can we do the `GenericTypeInfo` type check in `TableEnvironment.validateType(inputType)`
method? If we do so, we can remove the duplicate check. What do you think?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message