flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...
Date Wed, 15 Mar 2017 13:17:53 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala
    @@ -25,6 +25,7 @@ import org.apache.flink.table.sources.TableSource
     /** Table which defines an external table via a [[TableSource]] */
     class TableSourceTable[T](
         val tableSource: TableSource[T],
    +    val tableEnv: TableEnvironment,
    --- End diff --
    Do we really need this reference here? I think it is only needs to provide the FunctionCatalog
for translating RexNodes into Expressions for filter pushdown. Isn't the catalog of built-in
functions sufficient for that (which is available as a static object)? I don't think a TableSource
would be able to evaluate a predicate that includes a UDF, so the built-in functions should
be enough and we do not need to add the `TableEnvironment` here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message