flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...
Date Tue, 14 Mar 2017 09:34:48 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3477#discussion_r105851817
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -71,19 +70,16 @@
     	private final NonDuplicatingTypeSerializer<T> nonDuplicatingTypeSerializer;
     
     	// Buffer used to store the matched events
    --- End diff --
    
    I've changed it to String because, one `Pattern` can be compiled into multiple `State`s.
I assumed the name is unique for `Pattern` and when the resulting matches are returned we
want to have events grouped by the `Pattern` name in `Map<String, Event>`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message