flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...
Date Mon, 13 Mar 2017 16:27:43 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3477#discussion_r105704267
  
    --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
    @@ -272,37 +372,42 @@ public void testBranchingPattern() {
     			public boolean filter(Event value) throws Exception {
     				return value.getName().equals("start");
     			}
    -		})
    -			.followedBy("middle-first").subtype(SubEvent.class).where(new FilterFunction<SubEvent>()
{
    +		}).followedBy("middle-first").subtype(SubEvent.class)
    +			.where(new FilterFunction<SubEvent>() {
     				private static final long serialVersionUID = 6215754202506583964L;
     
     				@Override
     				public boolean filter(SubEvent value) throws Exception {
    -					return value.getVolume() > 5.0;
    +					return value.getVolume() >
    --- End diff --
    
    this can be as before, in one line. In general we try to minimize unnecessary changes
;).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message