flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...
Date Mon, 13 Mar 2017 15:07:19 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3445#discussion_r105683186
  
    --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java
---
    @@ -240,4 +270,159 @@ public Byte getKey(Event value) throws Exception {
     			return 0;
     		}
     	}
    -}
    +
    --- End diff --
    
    Is this the complete code that can be used to regenerate the snapshot files?
    
    I think `WindowOperatorMigrationTest.testRestoreSessionWindowsWithCountTriggerFromFlink11()`
shows how the code that generates the snapshot and the testing code can be interleaved nicely.
This format also makes it easy (hopefully, as I will soon find out because I'm re-writing
the tests for Flink 1.3 (https://issues.apache.org/jira/browse/FLINK-5969)) to update/adapt
the tests on version updates of Flink.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message