flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink
Date Fri, 10 Mar 2017 14:17:25 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r105397306
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.util;
    +
    +import static java.util.Objects.requireNonNull;
    +
    +import java.io.IOException;
    +import java.io.ObjectInputStream;
    +import java.io.Serializable;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.functions.InvalidTypesException;
    +import org.apache.flink.api.common.typeinfo.TypeHint;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +
    +
    +/**
    + * An {@link OutputTag} is a typed and named tag to use for tagging side outputs
    + * of an operator.
    + *
    + * <p>An {@code OutputTag} must always be an anonymous inner class so that Flink
can derive
    + * a {@link TypeInformation} for the generic type parameter.
    + *
    + * <p>Example:
    + * <pre>{@code
    + * OutputTag<Tuple2<String, Long>> info = new OutputTag<Tuple2<String,
Long>>("late-data"){});
    + * }</pre>
    + *
    + * @param <T> the type of elements in the side-output stream.
    + */
    +@PublicEvolving
    +public class OutputTag<T> implements Serializable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private final String id;
    +
    +	private transient TypeInformation<T> typeInfo;
    +
    +	/**
    +	 * Creates a new named {@code OutputTag} with the given id.
    +	 *
    +	 * @param id The id of the created {@code OutputTag}.
    +     */
    +	public OutputTag(String id) {
    +		Preconditions.checkNotNull(id, "OutputTag id cannot be null.");
    --- End diff --
    
    We do not need both lines with the checks. We can just have:
    
    `this.id = Preconditions.checkNotNull(id, "OutputTag id cannot be null.");`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message