flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink
Date Fri, 10 Mar 2017 14:17:25 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r105401503
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
    @@ -387,14 +403,25 @@ public int getChainLength() {
     
     		protected final StreamStatusProvider streamStatusProvider;
     
    -		public ChainingOutput(OneInputStreamOperator<T, ?> operator, StreamStatusProvider
streamStatusProvider) {
    +		protected final OutputTag<T> outputTag;
    +
    +		public ChainingOutput(
    +				OneInputStreamOperator<T, ?> operator,
    +				StreamStatusProvider streamStatusProvider,
    +				OutputTag<T> outputTag) {
     			this.operator = operator;
     			this.numRecordsIn = ((OperatorMetricGroup) operator.getMetricGroup()).getIOMetricGroup().getNumRecordsInCounter();
     			this.streamStatusProvider = streamStatusProvider;
    +			this.outputTag = outputTag;
     		}
     
     		@Override
    --- End diff --
    
    Again the two `collect()` methods have much identical code. We can put that common code
in a separate private method and calls this instead of repeating the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message