flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3466: [FLINK-5715] Asynchronous snapshots for heap-based...
Date Fri, 10 Mar 2017 12:49:33 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3466#discussion_r105390074
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
---
    @@ -97,6 +100,27 @@ public FsStateBackend(String checkpointDataUri) throws IOException
{
     	 *
     	 * @param checkpointDataUri The URI describing the filesystem (scheme and optionally
authority),
     	 *                          and the path to the checkpoint data directory.
    +	 * @param asynchronousSnapshots Switch to enable asynchronous snapshots.
    +	 *
    +	 * @throws IOException Thrown, if no file system can be found for the scheme in the
URI.
    +	 */
    +	public FsStateBackend(String checkpointDataUri, boolean asynchronousSnapshots) throws
IOException {
    --- End diff --
    
    I guess this is then typically a case where you could go for a builder pattern, only problem
i see here that this would be API breaking. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message