flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...
Date Fri, 10 Mar 2017 11:49:19 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3406#discussion_r105382341
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
    @@ -0,0 +1,138 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.catalog
    +
    +import java.io.IOException
    +import java.lang.reflect.Modifier
    +import java.net.URL
    +import java.util.Properties
    +
    +import org.apache.flink.table.annotation.ExternalCatalogCompatible
    +import org.apache.flink.table.api.ExternalCatalogTableTypeNotExistException
    +import org.apache.flink.table.plan.schema.TableSourceTable
    +import org.apache.flink.table.plan.stats.FlinkStatistic
    +import org.apache.flink.table.sources.TableSource
    +import org.apache.flink.util.InstantiationUtil
    +import org.reflections.Reflections
    +import org.slf4j.{Logger, LoggerFactory}
    +
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable.HashMap
    +
    +/**
    +  * The utility class is used to convert ExternalCatalogTable to TableSourceTable.
    +  */
    +object CatalogTableHelper {
    +
    +  // config file to specifier the scan package to search tableSources
    +  // which is compatible with external catalog.
    +  private val tableSourceConfigFileName = "externalCatalogTable.properties"
    --- End diff --
    
    Sorry, I think I confused something there. 
    The approach to have a resource file in each Module / Jar that offers converters is good.
Hard-coding the name of the resource file is fine.
    
    Thinking this one step further, would it make sense to not use scanning at all but exactly
specify the Converter classes? Then we would not need to use the reflection library to scan
the class path. Just as an idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message