flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #3459: [FLINK-5654] Add processing time OVER RANGE BETWEEN x PRE...
Date Fri, 10 Mar 2017 09:46:10 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3459
  
    Hi @huawei-flink, 
    
    most Maven modules in Flink are implemented in either Java or Scala. We have a few modules
(like flink-runtime) which are mixed but didn't make good experience with this design. Also,
there is a clear separation in these modules which components are implemented in Java and
Scala. I think implementing the flink-table module in a mix of Java and Scala is not a good
idea because it makes the maintenance more difficult than sticking to a single language. 
    
    Regarding the squashing. I think the best approach is to create a new branch based on
the current master and manually copying over those files that you would like to keep. Most
of the code should be new files, so this should not be too much effort. By using the first
OVER window as a blueprint I meant that you should try to follow a similar approach by using
the same utils and a similar design. IMO, it makes sense if similar features share as much
code as possible and follow the same design.
    
    Best, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message