flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink
Date Thu, 09 Mar 2017 17:42:55 GMT
Github user kl0u commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
    @@ -419,6 +435,14 @@ public void merge(W mergeResult,
    +		// side output input event if
    +		// element not handled by any window
    +		// late arriving tag has been set
    +		// windowAssigner is event time and current timestamp + allowed lateness no less than
element timestamp
    +		if(isSkippedElement && lateDataOutputTag != null && isLate(element))
    --- End diff --
    @chenqin and @aljoscha I am starting to review the PR and I was wondering when is this
new `isLate()` check needed? At least for the out-of-box window assigners, this seems to be
a redundant check.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message