flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...
Date Thu, 09 Mar 2017 14:46:32 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3406#discussion_r105138128
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
    @@ -0,0 +1,114 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.catalog
    +
    +import java.util
    +
    +/**
    +  * This class is responsible for interact with external catalog.
    +  * Its main responsibilities including:
    +  * <ul>
    +  * <li> create/drop/alter database or tables for DDL operations
    +  * <li> provide tables for calcite catalog, it looks up databases or tables in
the external catalog
    +  * </ul>
    +  */
    +trait ExternalCatalog {
    +
    +  /**
    +    * Adds table into external Catalog
    +    *
    +    * @param table          description of table which to create
    +    * @param ignoreIfExists whether to ignore operation if table already exists
    --- End diff --
    
    I think we should make the expected behavior of all methods more clear: When is an operation
performed, when is an exception thrown, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message