flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3466: [FLINK-5715] Asynchronous snapshots for heap-based keyed ...
Date Thu, 09 Mar 2017 10:11:10 GMT
Github user StephanEwen commented on the issue:

    I think this is all in all very good code!
    One thing I am worried about is the testing time now. The `EventTimeWindowCheckpointingITCase`
tests already take super long, now we have two more.
    What we should probably do is make the following:
      - The data volume is very high in that test, and I think that was mainly done to stress
RocksDB's async snapshots a bit.
      - The heaviness can be moved to a RocksDB specific async snapshot test (that does not
need to use windows)
      - The base of the EventTimeWindowCheckpointingITCases can then be made much more lightweight.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message