flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3443: [FLINK-5653] Add processing time OVER ROWS BETWEEN...
Date Wed, 08 Mar 2017 22:56:58 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3443#discussion_r105046076
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamCalcRule.scala
---
    @@ -46,6 +52,20 @@ class DataStreamCalcRule
           calc.getProgram,
           description)
       }
    +
    +  override def matches(call: RelOptRuleCall): Boolean = {
    --- End diff --
    
    This can be removed because the `RexOver` was removed from `Project` (and Calc`) during
normalization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message