flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...
Date Wed, 08 Mar 2017 22:06:31 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3040#discussion_r105014912
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
    @@ -125,11 +126,25 @@ class DataSetAggregate(
             .name(aggOpName)
         }
         else {
    +      //Forward all fields at conversion
    +      val inputInfo = mappedInput.getType
    --- End diff --
    
    PR #3472 will remove the preparing mapper but add a `GroupCombineFunction`. For both,
the combiner and the reducer, we need to forward the fields on which is grouped because these
are not modified but just forwarded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message