flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...
Date Wed, 08 Mar 2017 13:38:44 GMT
Github user StephanEwen commented on the issue:

    Another thought from the discussion with @StefanRRichter :
    You refactor a lot to not have duplicate code. While this is good in general, I am wondering
if we should not actually duplicate the code here, because we want the `V1` serialization
code and savepoint code to be "immutable", meaning it should not be affected by changes to
the `V2` code. Having a copy makes sure no accidental changes are made to the `V1` code when
modifying the `V2` code.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message