flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenqin <...@git.apache.org>
Subject [GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink
Date Wed, 08 Mar 2017 05:46:50 GMT
Github user chenqin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r104847832
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
    @@ -439,6 +450,7 @@ public static boolean isChainable(StreamEdge edge, StreamGraph streamGraph)
{
     					headOperator.getChainingStrategy() == ChainingStrategy.ALWAYS)
     				&& (edge.getPartitioner() instanceof ForwardPartitioner)
     				&& upStreamVertex.getParallelism() == downStreamVertex.getParallelism()
    +				&& edge.getOutputTag() == null // disable chaining for side outputs
    --- End diff --
    
    I remember you mentioned latest version side output works with chain or no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message