flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3468: [FLINK-5824] Fix String/byte conversions without explicit...
Date Tue, 07 Mar 2017 10:58:32 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3468
  
    I would prefer to keep the value in `ConfigConstants`, just because it clearly defines
in one place what we want to use as the default (rather than passing `StandardCharsets.UTF_8`
everywhere).
    
    As for the name, I think both suggestions are fine in the end. It is unlikely that we
ever switch the charset, especially since checkpoints and high-availability storage encodes
data in that charset.
    
    What would be good to have is a test that checks that we never use a byte conversion without
a charset. Maybe a checkstyle rule. If that does not work, we can try and do a `Reflections`
test (see RpcCompletenessTest for an example of how to reflectively analyze code in tests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message