flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...
Date Tue, 07 Mar 2017 07:56:56 GMT
Github user KurtYoung commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
    @@ -42,6 +41,14 @@ class DataSetAggregateRule
           return false
    +    // distinct is translated into dedicated operator
    +    if (agg.getAggCallList.isEmpty &&
    +      agg.getGroupCount == agg.getRowType.getFieldCount &&
    --- End diff --
    Why we should check the group count and row type here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message