flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...
Date Tue, 07 Mar 2017 03:58:10 GMT
Github user KurtYoung commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
    @@ -140,6 +138,26 @@ object UserDefinedFunctionUtils {
               s"one method named 'eval' which is public, not abstract and " +
               s"(in case of table functions) not static.")
         } else {
    +      methods.foreach(method => {
    --- End diff --
    Can we move this check to a method like verifyScalaVarargsAnnotation ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message