flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results
Date Sat, 04 Mar 2017 21:06:44 GMT
Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/3434
  
    Hi @greghogan, thank you for the PR.
    
    I didn't spot anything that needs fixing, but I'm wondering what's the motivation to add
these interfaces. I see how `toVerboseString()` is useful, but not really why `AnalyticResult`
is needed. Also, why introduce  `UnaryResult`, `BinaryResult`, and `TertiaryResult` instead
of simply using tuple types?
    
    I also see that this PR contains no changes to the docs and that the current 1.3-SNAPSHOT
docs already reflect the changes of this PR. What am I missing here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message