flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shijinkui <...@git.apache.org>
Subject [GitHub] flink pull request #3408: [FLINK-5903][YARN]respect taskmanager.numberOfTask...
Date Sat, 04 Mar 2017 03:20:53 GMT
Github user shijinkui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3408#discussion_r104277608
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor createDescriptor(String defaultApplicationN
     		if (cmd.hasOption(SLOTS.getOpt())) {
     			int slots = Integer.valueOf(cmd.getOptionValue(SLOTS.getOpt()));
     			yarnClusterDescriptor.setTaskManagerSlots(slots);
    +		} else if (config.containsKey(ConfigConstants.YARN_VCORES)) {
    --- End diff --
    
    @tillrohrmann I'm agree with you. We need make sense that YARN_VCORES is available  in
yarn mode, and yarn/mesos/standalone should have different configuration. And `YARN_VCORES`
is the sum of `Resource#getVirtualCores` response from yarn client.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message