flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...
Date Fri, 03 Mar 2017 16:54:09 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
    @@ -0,0 +1,63 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.annotation;
    +import org.apache.flink.annotation.Public;
    +import org.apache.flink.table.catalog.TableSourceConverter;
    +import java.lang.annotation.Documented;
    +import java.lang.annotation.ElementType;
    +import java.lang.annotation.Retention;
    +import java.lang.annotation.RetentionPolicy;
    +import java.lang.annotation.Target;
    + * A tableSource with this annotation represents it is compatible with external catalog,
that is,
    + * an instance of this tableSource can be converted to or converted from external catalog
    + * instance.
    + * The annotation contains the following information:
    + * <ul>
    + * <li> external catalog table type name for this kind of tableSource </li>
    + * <li> external catalog table <-> tableSource converter class </li>
    + * </ul>
    + */
    +public @interface ExternalCatalogCompatible {
    --- End diff --
    I think we should add a version field here as well to support multiple versions of Converters.
    This might become important when the `TableSource` evolves or if we have different `TableSources`
or for the same table type. 
    So either 
    - `[$tableType:$version -> TableConverter]+`, which would allow support for different
table types or 
    - `$tableType, [$version -> TableConverter]+`, which limits a `TableSource` to one
table type but multiple versions of it.
    What do you think @beyond1920, @KurtYoung ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message