flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3408: [FLINK-5903][YARN]respect taskmanager.numberOfTask...
Date Fri, 03 Mar 2017 10:42:09 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
    @@ -537,7 +543,6 @@ public YarnClusterClient createCluster(
     		Preconditions.checkNotNull(userJarFiles, "User jar files should not be null.");
     		AbstractYarnClusterDescriptor yarnClusterDescriptor = createDescriptor(applicationName,
    -		yarnClusterDescriptor.setFlinkConfiguration(config);
    --- End diff --
    You cannot simply ignore the `configuration` which has been given to `createCluster`.
What if it contains configuration values which were added programmatically?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message