flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3408: [FLINK-5903][YARN]respect taskmanager.numberOfTask...
Date Fri, 03 Mar 2017 10:42:09 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3408#discussion_r104128524
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor createDescriptor(String defaultApplicationN
     		if (cmd.hasOption(SLOTS.getOpt())) {
     			int slots = Integer.valueOf(cmd.getOptionValue(SLOTS.getOpt()));
     			yarnClusterDescriptor.setTaskManagerSlots(slots);
    +		} else if (config.containsKey(ConfigConstants.YARN_VCORES)) {
    --- End diff --
    
    Actually, I'm not so sure whether whether we should use the `YARN_VCORES` value as a fallback
value for the number of task manager slots. We had this in the past but we changed it so that
the default behaviour is if the number of slots is not specified, then it is `1`. Changing
this here for Yarn would make the behaviour inconsistent wrt Mesos, for example. From a user's
perspective the old behaviour is imo more predictable. However, we should definitely respect
the configuration file settings for the task manager slots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message