flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3391: [FLINK-5758] [yarn] support port range for web mon...
Date Fri, 03 Mar 2017 10:11:00 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3391#discussion_r103956163
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -1252,8 +1257,8 @@
     			.noDefaultValue();
     
     	/** The config key for the port of the JobManager web frontend.
    -	 * Setting this value to {@code -1} disables the web frontend. */
    -	public static final int DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT = 8081;
    +	 * Setting this value to {@code "-1"} disables the web frontend. */
    +	public static final String DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT = "8081";
    --- End diff --
    
    To be honest, I'm not sure whether we can make this change, because `DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT`
is part of Flink's public API and, thus, your change is API breaking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message