flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3423: [FLINK-5768] [table] Apply new aggregation functio...
Date Wed, 01 Mar 2017 17:22:45 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3423#discussion_r103734677
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetTumbleTimeWindowAggReduceGroupFunction.scala
---
    @@ -99,8 +106,8 @@ class DataSetTumbleTimeWindowAggReduceGroupFunction(
         // get final aggregate value and set to output.
         aggregateMapping.foreach {
           case (after, previous) => {
    -        val accumulator =
    -          aggregateBuffer.getField(accumStartPos + previous).asInstanceOf[Accumulator]
    +        val agg = aggregates(previous)
    +        val accumulator = agg.merge(accumulatorList(previous))
             val result = aggregates(previous).getValue(accumulator)
    --- End diff --
    
    `aggregates(previous)` -> `agg`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message