Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 78B49200C0E for ; Wed, 1 Feb 2017 19:59:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 77377160B46; Wed, 1 Feb 2017 18:59:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C0E30160B41 for ; Wed, 1 Feb 2017 19:59:55 +0100 (CET) Received: (qmail 14422 invoked by uid 500); 1 Feb 2017 18:59:55 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 14412 invoked by uid 99); 1 Feb 2017 18:59:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Feb 2017 18:59:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F27A1189B4D for ; Wed, 1 Feb 2017 18:56:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 02bc6QmKN7Zk for ; Wed, 1 Feb 2017 18:56:57 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 562455F238 for ; Wed, 1 Feb 2017 18:56:56 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10DBEE040A for ; Wed, 1 Feb 2017 18:56:55 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9347B2528C for ; Wed, 1 Feb 2017 18:56:52 +0000 (UTC) Date: Wed, 1 Feb 2017 18:56:52 +0000 (UTC) From: "Dawid Wysakowicz (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5510) Replace Scala Future with FlinkFuture in QueryableStateClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 01 Feb 2017 18:59:56 -0000 [ https://issues.apache.org/jira/browse/FLINK-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848778#comment-15848778 ] Dawid Wysakowicz commented on FLINK-5510: ----------------------------------------- Just had a look into the code and been wondering how much of the futures do we want to replace. Just the return values in {{QueryableStateClient}} or every usage in QueryableStateClient/KvStateLookupService? If the former there is {{Future#recoverWith}} alternative missing in {{FlinkFuture}}. > Replace Scala Future with FlinkFuture in QueryableStateClient > ------------------------------------------------------------- > > Key: FLINK-5510 > URL: https://issues.apache.org/jira/browse/FLINK-5510 > Project: Flink > Issue Type: Improvement > Components: Queryable State > Reporter: Ufuk Celebi > Assignee: Dawid Wysakowicz > Priority: Minor > > The entry point for queryable state users is the {{QueryableStateClient}} which returns query results via Scala Futures. Since merging the initial version of QueryableState we have introduced the FlinkFuture wrapper type in order to not expose our Scala dependency via the API. > Since APIs tend to stick around longer than expected, it might be worthwhile to port the exposed QueryableStateClient interface to use the FlinkFuture. Early users can still get the Scala Future via FlinkFuture#getScalaFuture(). -- This message was sent by Atlassian JIRA (v6.3.15#6346)