Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 28 Feb 2017 15:03:45 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13032550.1483709925000.18839.1488294225300@Atlassian.JIRA>
In-Reply-To: <JIRA.13032550.1483709925000@Atlassian.JIRA>
References: <JIRA.13032550.1483709925000@Atlassian.JIRA> <JIRA.13032550.1483709925734@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-5420) Make CEP operators rescalable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Feb 2017 15:03:50 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888165#comment-15888165 ] 

ASF GitHub Bot commented on FLINK-5420:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3412#discussion_r103471738
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OnWatermarkCallback.java ---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api.operators;
    +
    +import org.apache.flink.streaming.api.watermark.Watermark;
    +
    +import java.io.IOException;
    +
    +/**
    + * A callback registered with the {@link InternalWatermarkCallbackService} service. This callback will
    + * be invoked for all keys registered with the service, upon reception of a watermark.
    + */
    +public interface OnWatermarkCallback<KEY> {
    --- End diff --
    
    This should probably also be `@Internal`.


> Make CEP operators rescalable
> -----------------------------
>
>                 Key: FLINK-5420
>                 URL: https://issues.apache.org/jira/browse/FLINK-5420
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>    Affects Versions: 1.2.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>
> This issue targets making the operators in the CEP library re-scalable. After this is implemented, the user will be able to take a savepoint and restart his job with a different parallelism.
> This issue depends on https://issues.apache.org/jira/browse/FLINK-5845. 
> The way this is done is that we introduce the {{TimeServiceHandler}} in the {{AbstractStreamOperator}}, which keeps the registered {{InternalTimerService}} s (before this was in the {{AbstractStreamOperator}}) and a new service called {{KeyRegistry}}. The {{KeyRegistry}} will be fault tolerant and rescalable and will allow to register keys and a callback which will be invoked for each registered key upon reception of a watermark. This can be seen as keeping (recurring) timers for each of the registered keys that will fire "at the next watermark".
> After introducing this service, upon reception of a watermark, all the processing of the NFAs will be delegated to the callback.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)