Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 15 Feb 2017 22:38:44 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12963528.1461859286000.92178.1487198324969@Atlassian.JIRA>
In-Reply-To: <JIRA.12963528.1461859286000@Atlassian.JIRA>
References: <JIRA.12963528.1461859286000@Atlassian.JIRA> <JIRA.12963528.1461859286568@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-3849) Add FilterableTableSource interface
 and translation rule
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Feb 2017 22:38:57 -0000


    [ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868732#comment-15868732 ] 

ASF GitHub Bot commented on FLINK-3849:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3166#discussion_r101302191
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/PushFilterIntoBatchTableSourceScanRule.scala ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.plan.rules.dataSet
    +
    +import org.apache.calcite.plan.RelOptRule._
    +import org.apache.calcite.plan.{RelOptRule, RelOptRuleCall}
    +import org.apache.flink.table.plan.nodes.dataset.{BatchTableSourceScan, DataSetCalc}
    +import org.apache.flink.table.plan.rules.util.RexProgramExpressionExtractor._
    +import org.apache.flink.table.sources.FilterableTableSource
    +
    +class PushFilterIntoBatchTableSourceScanRule extends RelOptRule(
    +  operand(classOf[DataSetCalc],
    +    operand(classOf[BatchTableSourceScan], none)),
    +  "PushFilterIntoBatchTableSourceScanRule") {
    +
    +  override def matches(call: RelOptRuleCall) = {
    +    val scan: BatchTableSourceScan = call.rel(1).asInstanceOf[BatchTableSourceScan]
    +    scan.tableSource match {
    +      case _: FilterableTableSource => true
    +      case _ => false
    +    }
    +  }
    +
    +  override def onMatch(call: RelOptRuleCall): Unit = {
    +    val calc: DataSetCalc = call.rel(0).asInstanceOf[DataSetCalc]
    +    val scan: BatchTableSourceScan = call.rel(1).asInstanceOf[BatchTableSourceScan]
    +
    +    val tableSource = scan.tableSource.asInstanceOf[FilterableTableSource]
    +
    +    val expression = extractExpression(calc.calcProgram)
    +    val unusedExpr = tableSource.setPredicate(expression)
    --- End diff --
    
    rename to `remainingPredicate`


> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>
>                 Key: FLINK-3849
>                 URL: https://issues.apache.org/jira/browse/FLINK-3849
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Anton Solovev
>
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations which support filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
>   // returns unsupported predicate expression
>   def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a TableScan that refers to a {{FilterableTableSource}}. We might need to tweak the cost model as well to push the optimizer in the right direction.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)