Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: sunjincheng121 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3386-flink@git.apache.org>
In-Reply-To: <git-pr-3386-flink@git.apache.org>
Subject: [GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...
Content-Type: text/plain
Message-Id: <20170223051101.18DA4DFC1C@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 05:11:01 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 05:11:05 -0000

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3386#discussion_r102633283
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala ---
    @@ -395,7 +395,8 @@ object AggregateUtil {
         val reduceFunction = new IncrementalAggregateReduceFunction(
           aggregates,
           groupingOffsetMapping,
    -      intermediateRowArity)
    +      intermediateRowArity,
    +      groupings.length)
    --- End diff --
    
    Can we distinguish between groupwWindow'grouping and overWindow'partition?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---