Return-Path: <issues-return-94103-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 22F4C200C22
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 21 Feb 2017 14:50:17 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 21935160B68; Tue, 21 Feb 2017 13:50:17 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 6B99E160B3E
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 21 Feb 2017 14:50:16 +0100 (CET)
Received: (qmail 14265 invoked by uid 500); 21 Feb 2017 13:50:15 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 14256 invoked by uid 99); 21 Feb 2017 13:50:15 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 13:50:15 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 47077C0CA7
	for <issues@flink.apache.org>; Tue, 21 Feb 2017 13:50:15 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id NERpv-39Iz6C for <issues@flink.apache.org>;
	Tue, 21 Feb 2017 13:50:14 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 40E055F2C2
	for <issues@flink.incubator.apache.org>; Tue, 21 Feb 2017 13:50:14 +0000 (UTC)
Received: (qmail 14251 invoked by uid 99); 21 Feb 2017 13:50:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 13:50:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B903DDFF0F; Tue, 21 Feb 2017 13:50:13 +0000 (UTC)
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3348-flink@git.apache.org>
In-Reply-To: <git-pr-3348-flink@git.apache.org>
Subject: [GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...
Content-Type: text/plain
Message-Id: <20170221135013.B903DDFF0F@git1-us-west.apache.org>
Date: Tue, 21 Feb 2017 13:50:13 +0000 (UTC)
archived-at: Tue, 21 Feb 2017 13:50:17 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3348#discussion_r102210056
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -227,6 +227,14 @@
     	public static final String TASK_MANAGER_NETWORK_NUM_BUFFERS_KEY = "taskmanager.network.numberOfBuffers";
     
     	/**
    +	 * Boolean flag to enable/disable more detailed metrics about inbound/outbound network queue lengths
    +	 */
    +	@PublicEvolving
    +	public static final ConfigOption<Boolean> NETWORK_DETAILED_METRICS_KEY =
    --- End diff --
    
    I don't think ConfigOptions are supposed to be in this class; itshould be moved to either ```NetworkOptions``` or ```MetricOptions```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---